-
Notifications
You must be signed in to change notification settings - Fork 0
+9
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HendrikSchultheis
requested changes
Jan 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from typos look great.
README.md
Outdated
@@ -69,7 +69,7 @@ Optional arguments: | |||
--window_length INT This parameter sets the length of a sliding window. (Default: 200) | |||
--step INT This parameter sets the number of positions to slide the window forward. (Default: 100) | |||
--percentage INT Threshold in percent (Default: 0) | |||
--max_bp_between INT If footprints are less than X bases appart the footprints will be merged (Default: 6) | |||
--min_gap INT If footprints are less than X bases appart the footprints will be merged (Default: 6) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*apart
pipeline.nf
Outdated
@@ -57,6 +58,7 @@ | |||
|
|||
params.best_motif = 3 // Top n motifs per cluster | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this line
pipeline.nf
Outdated
@@ -86,7 +88,7 @@ Optional arguments: | |||
--window_length INT This parameter sets the length of a sliding window. (Default: 200) | |||
--step INT This parameter sets the number of positions to slide the window forward. (Default: 100) | |||
--percentage INT Threshold in percent (Default: 0) | |||
--max_bp_between INT If footprints are less than X bases appart the footprints will be merged (Default: 6) | |||
--min_gap INT If footprints are less than X bases appart the footprints will be merged (Default: 6) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*apart
HendrikSchultheis
approved these changes
Jan 14, 2019
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.